Skip to content

fix: improve libtiff checker #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Improve libtiff checker to avoid a false positive with upcoming emacs checker. While at it, add debian and OpenWRT test packages

Improve libtiff checker to avoid a false positive with upcoming emacs
checker. While at it, add debian and OpenWRT test packages

Signed-off-by: Fabrice Fontaine <[email protected]>
@ffontaine ffontaine force-pushed the fix-libtiff-checker branch from a64c528 to e93bb5d Compare May 10, 2023 05:06
@codecov-commenter
Copy link

Codecov Report

Merging #2985 (e93bb5d) into main (9bdba0c) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
- Coverage   82.67%   82.16%   -0.51%     
==========================================
  Files         674      674              
  Lines       10626    10626              
  Branches     1426     1426              
==========================================
- Hits         8785     8731      -54     
- Misses       1474     1531      +57     
+ Partials      367      364       -3     
Flag Coverage Δ
longtests 82.16% <100.00%> (+5.74%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data/libtiff.py 100.00% <ø> (ø)
cve_bin_tool/checkers/libtiff.py 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Now I'll have to remember to edit the emacs checker on merge.

@terriko terriko merged commit 6e807b1 into intel:main May 10, 2023
@ffontaine ffontaine deleted the fix-libtiff-checker branch May 10, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants