fix: improve other_products #2579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
force-pushed
the
fix-other-products
branch
4 times, most recently
from
2a3b625 to
baa8ea8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
+ Coverage 75.04% 83.00% +7.96%
==========================================
Files 596 598 +2
Lines 9736 9874 +138
Branches 1152 1354 +202
==========================================
+ Hits 7306 8196 +890
+ Misses 2123 1343 -780
- Partials 307 335 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ffontaine
force-pushed
the
fix-other-products
branch
5 times, most recently
from
6319f57 to
0b93c00
Compare
- Raise an error if one of the other_products is not found in the product list - Do not always append kerberos to all_the_tests (kerberos package_test_data will be provided by intel#2509) - Drop gcc, glibc, rust, sqlite, zlib, etc. from other_products if needed Signed-off-by: Fabrice Fontaine <[email protected]>
ffontaine
force-pushed
the
fix-other-products
branch
from
0b93c00 to
bd414b4
Compare
terriko
reviewed
Jan 26, 2023
| @@ -43,7 +43,6 @@ | |||
| prod_list.append(i["product"]) | |||
| for i in prod_list: | |||
| all_the_tests.append(i) | |||
| all_the_tests.append("kerberos") | |||
There was a problem hiding this comment.
I asked about this in code review and I gather we need this because kerberos was missing some test data and wasn't getting automatically appended. Since I can't easily edit deleted lines from the code review interface, I think instead I'll open up a new issue to fix whatever's up with kerberos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabrice Fontaine [email protected]