Skip to content

test: improve test_csv2cve_valid_file for future failures #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023
Merged

test: improve test_csv2cve_valid_file for future failures #2548

merged 2 commits into from
Jan 23, 2023

Conversation

b31ngd3v
Copy link
Contributor

closes #2532

@codecov-commenter
Copy link

Codecov Report

Merging #2548 (3d43125) into main (13395ef) will decrease coverage by 0.86%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##             main    #2548      +/-   ##
==========================================
- Coverage   77.84%   76.98%   -0.87%     
==========================================
  Files         591      593       +2     
  Lines        9736     9757      +21     
  Branches     1323     1328       +5     
==========================================
- Hits         7579     7511      -68     
- Misses       1852     1946      +94     
+ Partials      305      300       -5     
Flag Coverage Δ
longtests 76.98% <91.17%> (+0.05%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/sqlite.py 56.52% <ø> (-0.93%) ⬇️
test/test_data/sqlite.py 100.00% <ø> (ø)
cve_bin_tool/error_handler.py 91.42% <57.14%> (-2.42%) ⬇️
cve_bin_tool/checkers/__init__.py 95.55% <100.00%> (ø)
cve_bin_tool/checkers/capnproto.py 100.00% <100.00%> (ø)
cve_bin_tool/output_engine/__init__.py 66.42% <100.00%> (-2.50%) ⬇️
test/test_cli.py 65.60% <100.00%> (-11.38%) ⬇️
test/test_csv2cve.py 100.00% <100.00%> (ø)
test/test_data/capnproto.py 100.00% <100.00%> (ø)
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution. Looks like the test fails are unrelated to this PR.

@terriko terriko merged commit 7280ba9 into intel:main Jan 23, 2023
@b31ngd3v b31ngd3v deleted the 2532 branch January 24, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: improve test_csv2cve_valid_file for future failures
3 participants