fix: improve ftp checker #2544
Merged
fix: improve ftp checker #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
reviewed
Jan 24, 2023
This checker is for netkit_ftp, not ftp so fix the CPE ID, rename files and add a debian test package Signed-off-by: Fabrice Fontaine <[email protected]>
ffontaine
force-pushed
the
fix-ftp-checker
branch
from
18dc759 to
5ae52c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2544 +/- ##
==========================================
+ Coverage 82.95% 83.08% +0.12%
==========================================
Files 594 594
Lines 9811 9811
Branches 1344 1344
==========================================
+ Hits 8139 8151 +12
+ Misses 1333 1319 -14
- Partials 339 341 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checker is for netkit_ftp, not ftp so fix the CPE ID, rename files and add a debian test package
Signed-off-by: Fabrice Fontaine [email protected]