fix: fix false positives with filename patterns #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
force-pushed
the
fix-filename-patterns
branch
from
c27b3e1 to
40b6b37
Compare
Use match instead of search to only detect a match at the beginning of the filename for FILENAME_PATTERNS otherwise false positives will be raised. For example: - named (i.e. bind) for systemd-hostnamed - eroute (i.e. openswan) for traceroute6 - scp (i.e. openssh) for libxt_dscp.so - libc (i.e. glibc) for libuClibc.so Signed-off-by: Fabrice Fontaine <[email protected]>
ffontaine
force-pushed
the
fix-filename-patterns
branch
from
40b6b37 to
df91643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
matchinstead ofsearchto only detect a match at the beginning of the filename forFILENAME_PATTERNSotherwise false positives will be raised. For example:named(i.e. bind) forsystemd-hostnamederoute(i.e. openswan) fortraceroute6scp(i.e. openssh) forlibxt_dscp.solibc(i.e. glibc) forlibuClibc.soSigned-off-by: Fabrice Fontaine [email protected]