Skip to content

fix(TestExtractFilePkg): avoid downloading files in tests #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2022
Merged

fix(TestExtractFilePkg): avoid downloading files in tests #1784

merged 3 commits into from
Jul 14, 2022

Conversation

b31ngd3v
Copy link
Contributor

the URL wasn't working and the pkg extract test was failing because of that

@terriko
Copy link
Contributor

terriko commented Jul 14, 2022

Ugh. If this is a source that's going to change regularly, we should really find a more archival mirror of this package or take out the test that uses it.

@b31ngd3v
Copy link
Contributor Author

Ugh. If this is a source that's going to change regularly, we should really find a more archival mirror of this package or take out the test that uses it.

what if we store the file locally?

@terriko
Copy link
Contributor

terriko commented Jul 14, 2022

Okay, I took a bit more of a look at this. I don't think we need a package with actual code in it to test this function, we just need a valid .pkg file that we know the contents of that can be validated in test_extract_file_pkg

Instead of getting a new URL, can you make a valid .pkg file with a text file in it or something so we can do the extract? It can be really small and should be stored in test/assets so we can skip the whole download portion.

We can probably ALSO do this with some of the other files we're currently downloading, but since none of them is actually broken that can be a separate PR.

If this passes I'll merge this PR just to fix CI, but if it doesn't pass CI I'm going to suggest we disable this test for now instead.

@b31ngd3v
Copy link
Contributor Author

this should work

image

@b31ngd3v b31ngd3v changed the title fix: update glib pkg name fix(TestExtractFilePkg): avoid downloading files in tests Jul 14, 2022
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions is still timing out, but this is working for me locally so I'm going to go ahead and approve.

@terriko terriko merged commit 337f002 into intel:main Jul 14, 2022
@b31ngd3v b31ngd3v deleted the fix_pkg_url branch July 14, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants