-
Notifications
You must be signed in to change notification settings - Fork 547
refactor: refactor javascript parser (#1721) #1722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
- Coverage 83.74% 83.57% -0.17%
==========================================
Files 307 308 +1
Lines 6589 6601 +12
Branches 1069 1070 +1
==========================================
- Hits 5518 5517 -1
- Misses 828 839 +11
- Partials 243 245 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This looks good to me now, but apparently a bunch of the CI didn't complete since the last change. I'm going to update the branch to address the aiohttpd error and re-run tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is behaving, so merging now!
Closes #1721