Skip to content

refactor: refactor javascript parser (#1721) #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 12, 2022
Merged

Conversation

XDRAGON2002
Copy link
Contributor

Closes #1721

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #1722 (3b7217b) into main (e7ac2ea) will decrease coverage by 0.16%.
The diff coverage is 92.45%.

@@            Coverage Diff             @@
##             main    #1722      +/-   ##
==========================================
- Coverage   83.74%   83.57%   -0.17%     
==========================================
  Files         307      308       +1     
  Lines        6589     6601      +12     
  Branches     1069     1070       +1     
==========================================
- Hits         5518     5517       -1     
- Misses        828      839      +11     
- Partials      243      245       +2     
Flag Coverage Δ
longtests 83.57% <92.45%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/parsers/javascript.py 91.83% <91.83%> (ø)
cve_bin_tool/parsers/__init__.py 66.66% <100.00%> (+66.66%) ⬆️
cve_bin_tool/version_scanner.py 74.20% <100.00%> (-2.15%) ⬇️
cve_bin_tool/available_fix/debian_cve_tracker.py 63.26% <0.00%> (-14.29%) ⬇️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 71.09% <0.00%> (+0.39%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@XDRAGON2002 XDRAGON2002 requested a review from terriko July 5, 2022 21:51
@terriko
Copy link
Contributor

terriko commented Jul 7, 2022

This looks good to me now, but apparently a bunch of the CI didn't complete since the last change. I'm going to update the branch to address the aiohttpd error and re-run tests now.

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label Jul 7, 2022
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is behaving, so merging now!

@terriko terriko merged commit 4980849 into intel:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer Need a maintainer to respond / help out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor an existing language parser to the new API format
3 participants