Skip to content

refactor(extractor): Prioritize 7z while extracting pkg files in windows #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

yashugarg
Copy link
Contributor

fixes #1688

refactor: extractor: prioritize 7z to extract pkg files in windows
@codecov-commenter
Copy link

Codecov Report

Merging #1689 (5312350) into main (e83d269) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
- Coverage   78.76%   78.51%   -0.26%     
==========================================
  Files         298      298              
  Lines        6188     6195       +7     
  Branches     1006     1008       +2     
==========================================
- Hits         4874     4864      -10     
- Misses       1096     1112      +16     
- Partials      218      219       +1     
Flag Coverage Δ
longtests 78.51% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/extractor.py 56.02% <0.00%> (-2.14%) ⬇️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 70.90% <0.00%> (+0.40%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yashugarg yashugarg changed the title refactor(extractor): Prioritizing 7z while extracting FreeBSD packages in windows refactor(extractor): Prioritize 7z while extracting pkg files in windows Jun 6, 2022
@terriko
Copy link
Contributor

terriko commented Jun 7, 2022

Not 100% sure why windows failed -- it looks like maybe a rate limiting issue? I've updated the branch with main so the tests can re-run in case the failure is transient.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the windows error was indeed transient. Time to merge! Thank you for finding this; I'm not sure I would have even noticed the performance impact since it gets masked by the slowness of the conda stuff in CI.

@terriko terriko merged commit c6fc6b5 into intel:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(extractor): Prioritize 7z while extracting FreeBSD packages in windows
3 participants