test: add test for CLI output dependant on reportlab existence #1641
Conversation
onyxcherry
changed the title
|
I wonder if the test isn't implementation-specific. Rather it should not, but it is a matter for consideration. |
onyxcherry
changed the title
|
So which title has trailing whitespace? |
test/test_cli.py
Outdated
| from importlib.machinery import ModuleSpec | ||
| from importlib.util import module_from_spec | ||
|
|
||
| my_test_filename = "reportlab_test_report.pdf" |
There was a problem hiding this comment.
Can we make sure this test runs in the temp directories like we've done with other tests? Sure, it's unlikely this filename will already be in use, but I'd rather just do it the right way. You should be able to use the same construction you're using for the curl test file below.
There was a problem hiding this comment.
(sorry about the multi-posted comments here a second ago: apparently if you delete pending comments they don't really delete correctly)
|
Oh, and the trailing whitespace thing should have been on the title of the pull request. It's... a bit weird how it handles it when the PR title is updated but the code is not. But the request title looks correct to me now so next time you do a code update that linter should pass. |
Create an output file in the temporary directory, change spoofed module's name
|
What's wrong with my code? |
|
Re-running failed jobs. I think Conda was just having weird delays (this has happened before) so I'm just going to let that test try to run again. |
No description provided.