fix: add urllib3 explicitly to avoid CVEs #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
- Coverage 78.57% 78.42% -0.16%
==========================================
Files 291 291
Lines 5975 5975
Branches 980 980
==========================================
- Hits 4695 4686 -9
- Misses 1067 1076 +9
Partials 213 213
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Since no one's complained about this I'm going to go ahead and merge it. It's not a functional necessity for us but it seems like encouraging non-vulnerable dependencies is the right thing to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib3 is used by requests. It had some CVEs last year (and before). Pip tends to be very conservative about upgrading packages and requests doesn't require a non-vulnerable version of the library, so I'm adding it to our requirements.txt file in order to force an upgrade for users of cve-bin-tool.
Probably not necessary, as these fixes have been out quite some time, but I happened upon a machine I was using for testing that had the older version, and figured I might as well set this up as a courtesy in case anyone else encounters a similar issue. This way, when you run
pip install --upgrade -r requirements.txturllib3 will be explicitly named and upgraded. (Without this line, upgrading the other packages would not upgrade urllib3.)