-
Notifications
You must be signed in to change notification settings - Fork 547
test(available-fix): mock cve data #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm should we move these mock data to a separate file? |
This will avoid running `check_json` in the tests else we would have to mock the `check_json` function.
should I revert #1512 in this PR? |
Yeah, might as well revert #1512 now that the tests don't use external data. Or if you prefer, keep a copy of the old external test and leave that in LONG_TESTS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you might want to rebase from main to get the other LONG_TESTS fix and see if that clears up CI.
Other than that, looks good. I'll need to remember to add pytest-mock to our licensing request for 3.1, but it's MIT so I don't anticipate any problem.
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 79.27% 80.39% +1.12%
==========================================
Files 281 281
Lines 5548 5571 +23
Branches 905 908 +3
==========================================
+ Hits 4398 4479 +81
+ Misses 966 897 -69
- Partials 184 195 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I've kept the old tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, thought I'd merged this earlier, but apparently not. Will do so now. Thank you again for getting this set up; I think it'll provide a baseline for moving a few other things to use mock eventually too.
fix #1503