Skip to content

fix(cvedb): skip reject cve entries #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021
Merged

fix(cvedb): skip reject cve entries #1282

merged 1 commit into from
Jul 27, 2021

Conversation

imsahil007
Copy link
Contributor

this will close #1269

@anthonyharrison
Copy link
Contributor

@imsahil007 This is exactly the same fix that I just tried!

@imsahil007
Copy link
Contributor Author

"""Test to match the totalResults and the total CVE count on NVD """

@anthonyharrison In #1218 I have added a test for verifying the CVE count exclusive of the rejected CVEs.
Should I add a similar test here?
Note: That test will require fetching all JSON feeds to compute CVE count in this case.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a potentially interesting test for us to check on any disparity between what we're getting and what NVD is reporting. We should see if we can combine it with any other test that downloads that data -- maybe the test_json stuff?

That said, I think this change is good as-is, so I'm going to go ahead and merge it without a test for now.

@terriko terriko merged commit 4eb3891 into intel:main Jul 27, 2021
@imsahil007 imsahil007 deleted the reject branch August 1, 2021 14:30
peb-peb pushed a commit to peb-peb/cve-bin-tool that referenced this pull request Aug 2, 2021
This helps close the gap we were seeing between the new and old API numbers: the new NVD API didn't report the rejected entries, but our code using the old API was storing entries in the db for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in CVE records b/w CVE retreival and cve.mitre
3 participants