Skip to content

fix: Too many SQL Variables #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 27, 2021
Merged

fix: Too many SQL Variables #1279

merged 18 commits into from
Jul 27, 2021

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1279 (69e0a88) into main (4449279) will decrease coverage by 1.47%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   80.74%   79.26%   -1.48%     
==========================================
  Files         252      252              
  Lines        4564     4573       +9     
  Branches      557      558       +1     
==========================================
- Hits         3685     3625      -60     
- Misses        741      802      +61     
- Partials      138      146       +8     
Flag Coverage Δ
longtests 79.26% <95.45%> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cve_scanner.py 77.34% <95.45%> (+1.71%) ⬆️
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_scanner.py 61.71% <0.00%> (-12.50%) ⬇️
test/test_cli.py 81.28% <0.00%> (-11.83%) ⬇️
cve_bin_tool/checkers/glibc.py 95.83% <0.00%> (-4.17%) ⬇️
cve_bin_tool/cli.py 75.15% <0.00%> (-3.04%) ⬇️
cve_bin_tool/version_scanner.py 76.38% <0.00%> (-1.39%) ⬇️
cve_bin_tool/cvedb.py 84.39% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4449279...69e0a88. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting -- I've never hit this sql limit before! (and I'm fondly remembered of the time my grandfather had to ask me to help him because he'd run out of columns in his stock tracking spreadsheets.)

@terriko terriko merged commit 061fc0d into intel:main Jul 27, 2021
peb-peb pushed a commit to peb-peb/cve-bin-tool that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants