Description
Windows short tests have been timing out at 30 minutes after the main tests have run but we're getting packages from conda to set up for the pdf tests. These tests are working correctly in the windows long tests. (I thought for sure that fixing the cache would resolve this issue but apparently getting packages through conda is just a little bit too slow.)
Two options:
- Remove the PDF tests from the short tests on windows. (They're clearly not short due to the extra setup time needed.)
- Extend the timeout on the windows tests to 45 mintues, which is what the long tests have.
I'm leaning towards option 1 because I'd rather the windows short tests actually take less time and the pdf tests are being run on the long tests as well as all the linux tests, which is probably sufficient to catch any regressions. I'm open to other brilliant ideas that will make this test faster, though!
This task is something a beginner can do. You'll be removing the conda & pdf test related lines in .github/workflows/testing.yml that start here:
https://github.com/intel/cve-bin-tool/blob/main/.github/workflows/testing.yml#L297
Short tips for new contributors:
- cve-bin-tool's contributor docs
- cve-bin-tool uses https://www.conventionalcommits.org/ style for commit messages, and we have a test that checks the title of your PR. A good potential title for this one is in the title of this issue.
- If you've contributed to open source but not this project, you might just want our checklist for a great pull request
- You can make an issue auto close by including a comment "fixes #ISSUENUMBER" in your PR comments where ISSUENUMBER is the actual number of the issue.