Skip to content

Make stat command use '-c' for Yocto OS #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

michaellihs
Copy link
Contributor

Description

When running inspec on a target with Yocto linux, the stat command used the --printf option instead of the -c switch. This causes e.g. the checking of file owners to break due to yocto using a different implementation of stat.

Related Issue

#558

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@michaellihs michaellihs requested a review from a team as a code owner January 17, 2020 10:56
@chef-expeditor
Copy link
Contributor

Hello michaellihs! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@ghost ghost requested review from clintoncwolfe and miah January 17, 2020 10:56
@codeclimate
Copy link

codeclimate bot commented Jan 17, 2020

Code Climate has analyzed commit 6d85d37 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 4

View more on Code Climate.

Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaellihs =)

Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@clintoncwolfe clintoncwolfe merged commit f6dab9f into inspec:master Jan 21, 2020
@clintoncwolfe clintoncwolfe added Type: New Feature Adds new functionality Type: Bug Feature not working as expected Platform: UNIX-Like and removed Type: New Feature Adds new functionality labels Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: UNIX-Like Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants