Skip to content

add unit test suite to check fct_* behaviour when input is not a factor #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

ayogasekaram
Copy link
Contributor

closes #18


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".
  • Create an issue in any repositories using {standalone} to update the standalone scripts.

@ayogasekaram ayogasekaram requested a review from ddsjoberg May 5, 2025 13:21
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @ayogasekaram !!

@ddsjoberg ddsjoberg merged commit 7628c35 into main May 5, 2025
7 checks passed
@ddsjoberg ddsjoberg deleted the 18_fct_tests@main branch May 5, 2025 14:14
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check forcats tests for non-factor inputs
2 participants