Update template@476 harmonize templates #499
Conversation
| export(lbt14) | ||
| export(lbt14_main) | ||
| export(lbt14_post) | ||
| export(lbt14_pre) |
There was a problem hiding this comment.
Undeniably it looks better
There was a problem hiding this comment.
if possible, I even don't want to export these main, pre and post. but for arguments we need them
…to update_template@476_harmonize_templates
…to update_template@476_harmonize_templates
| checkmate::assert_choice(pval_method, c("log-rank", "wald", "likelihood")) | ||
| checkmate::assert_choice(ties, c("efron", "breslow", "exact")) |
There was a problem hiding this comment.
how about make them part of the ... ? and control_coxph can take the check of arguments
R/kmg01.R
Outdated
| @@ -39,21 +40,33 @@ kmg01_1_main <- function(adam_db, | |||
| position_surv_med = c(0.9, 0.9), | |||
| line_col = as.list(nestcolor::color_palette()), | |||
There was a problem hiding this comment.
line_col can be named or unnamed; but it is not used. I think it could be make into ... and pass to g_ef_km
|
hi @BFalquet please note that EGT02 already has variants in the standard (egt02_1, egt02_2) |
…to update_template@476_harmonize_templates
If this is not a test, this is a particularly regrettable usage of the variants numbering, the only difference between the two is whether one parameter is true or false. |
also vst02 already has variant called vst02_1 and vst02_2; we can follow standards. I think it is not some test but long-standing template |
update rmpt01 and vst01