-
-
Notifications
You must be signed in to change notification settings - Fork 3
Closes #49 add formulas/document the methods of CI interval calculation in LaTeX #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 16 16
Lines 789 789
=======================================
Hits 785 785
Misses 4 4 ☔ View full report in Codecov by Sentry. |
@zdz2101 this is beautiful!! ❤️ what do you think of adding this as a section to the function help file instead of a standalone article? we could add it to the #' @section Method Details:
#'
#' ### Wald
#'
#' $$
#' \hat{p} \pm z_{\alpha/2} \sqrt{\frac{\hat{p}(1 - \hat{p})}{n}}
#' $$ Here's an example of Latex in a roxygen2 help file https://github.com/MSKCC-Epi-Bio/tidycmprsk/blob/543851ce4b3eeb82c037188f01e8c901a6448344/R/cuminc.R#L12 |
Code Coverage Summary
Diff against main
Results for commit: a956878 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 26 suites 4s ⏱️ Results for commit a956878. ♻️ This comment has been updated with latest results. |
@zdz2101 this looks so so good! My only request is if we can replace the old-school division sign with a large slash? If not, that is ok too. Thanks! ![]() |
done! |
@ddsjoberg not quite sure why one of the r-cmd-check (oldrel-1) is breaking now but I made the swap edit: reran the failed job and now it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just lovely!!! ❤️ thank you!
What changes are proposed in this pull request?
NEWS.md
. (#, @)Provide more detail here as needed.
write latex formulas of all the prop ci calculations
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).