Skip to content

Survival Estimates (quantiles & x-year survival estimates) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #6
ddsjoberg opened this issue Feb 6, 2024 · 0 comments · Fixed by #59
Closed
Tracked by #6

Survival Estimates (quantiles & x-year survival estimates) #43

ddsjoberg opened this issue Feb 6, 2024 · 0 comments · Fixed by #59
Assignees

Comments

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Feb 6, 2024

For this function we need it to accept a survival::survfit() object

@ddsjoberg ddsjoberg mentioned this issue Feb 6, 2024
9 tasks
@edelarua edelarua self-assigned this Feb 12, 2024
ddsjoberg added a commit that referenced this issue Apr 4, 2024
**What changes are proposed in this pull request?**
* Added function `ard_survfit` to create ARDs for `survfit` objects.

Closes #43 

Please let me know if there are any additional statistics that I should
include or if any restructuring is needed!


--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [x] **All** GitHub Action workflows pass with a ✅
- [x] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [x] If a bug was fixed, a unit test was added.
- [x] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [x] If a new `ard_*()` function was added, it passes the ARD
structural checks from `cards::check_ard_structure()`.
- [x] If a bug was fixed, a unit test was added.
- [x] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [x] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [x] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [ ] **All** GitHub Action workflows pass with a ✅
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

---------

Signed-off-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants