Skip to content

Implement cli call env functions #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edelarua opened this issue Apr 10, 2024 · 0 comments · Fixed by #112
Closed

Implement cli call env functions #111

edelarua opened this issue Apr 10, 2024 · 0 comments · Fixed by #112
Assignees
Labels
enhancement New feature or request sme

Comments

@edelarua
Copy link
Contributor

Update standalone files following ddsjoberg/standalone#7 and implement set_cli_abort_call in user-facing functions.

@edelarua edelarua added enhancement New feature or request sme labels Apr 10, 2024
@edelarua edelarua self-assigned this Apr 10, 2024
@edelarua edelarua mentioned this issue Apr 10, 2024
13 tasks
ddsjoberg added a commit that referenced this issue Apr 15, 2024
**What changes are proposed in this pull request?**
* Import cli call environment functions from the `standalone` repo and
implement `set_cli_abort_call` in user-facing functions. (#111,
@edelarua)

Closes #111


--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [x] **All** GitHub Action workflows pass with a ✅
- [x] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [x] If a bug was fixed, a unit test was added.
- [x] If a new `ard_*()` function was added, it passes the ARD
structural checks from `cards::check_ard_structure()`.
- [x] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [x] If a bug was fixed, a unit test was added.
- [x] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [x] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [x] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [x] **All** GitHub Action workflows pass with a ✅
- [x] Approve Pull Request
- [x] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

---------

Signed-off-by: Daniel Sjoberg <[email protected]>
Signed-off-by: Abinaya Yogasekaram <[email protected]>
Co-authored-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Abinaya Yogasekaram <[email protected]>
Co-authored-by: ddsjoberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant