Bunch of old patches #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link utilisation pie chart is always rather small, and that's because it has to be scaled down to fit the rather large labels. So make the labels shorter.
Instead of using screen coordinates in the sim output, use virtual positions and a declared world size. Then scale to the screen output in the final rendering. This allows fitting to the screen size more naturally, without needing to use combinators like LayoutScaleFit which scale everything, not just positions.
Use a proper Point type for coordinates, and a common world shape type for the size of the simulated world. Switch the P2P sim code from using DiffTime to Double as the representation of Latency. Also switch from using a (1,1) unit square as the virtual simulated world dimensions, to using the dimensions given as the latency and returning that in the P2PTopography. This eliminates a whole set of coordinate transformations, which is a source of bugs.
This is a better approximation of the internet: links go round the world but not over the poles. It should reduce the average link latency and so improve diffusion times.
In the P2P graph construction. Previously it was O(n^2), now it's (average time) O(log k * log n) for k neighbours out of n nodes. This uses a K-D tree, from the kdt package. https://en.wikipedia.org/wiki/Nearest_neighbor_search https://en.wikipedia.org/wiki/K-d_tree
The pre-processing for the perfect diffusion time is O(n^3) so is no good for large graphs.
This allows multiple lines with proper text wrapping.
The cylindrical world gets better diffusion times, and it also corresponds more closely to the internet which is connected around the middle but not over the poles.
@wenkokke seems like PRs from forks won't be able to pass checks because they will lack credentials. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are patches I had locally from a couple years ago that never made it to the upstream repo.
Some rebasing & edits may be needed to make them work in the current code.