Skip to content

fix(dmq): add missing KES period in 'DmqMsg' #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 15, 2025

Content

This PR includes a fix for the missing kes_period field in the DmqMsg struct following an update in the pallas crate.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2627

@jpraynaud jpraynaud self-assigned this Jul 15, 2025
Copy link

github-actions bot commented Jul 15, 2025

Test Results

    4 files  ±0    154 suites  ±0   22m 33s ⏱️ +2s
2 118 tests ±0  2 118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 466 runs  ±0  6 466 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 841640e. ± Comparison against base commit e52b52a.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2622-fix-kes-pallas branch from 1064600 to d7f4e35 Compare July 15, 2025 12:48
@jpraynaud jpraynaud requested a review from Copilot July 15, 2025 12:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing kes_period field to DmqMsg by:

  • Including kes_period in the message ID hash computation.
  • Fetching and assigning the current KES period in DmqMessageBuilder.
  • Updating tests and bumping the crate version.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
internal/mithril-dmq/src/message.rs Added kes_period hashing, builder logic, and test defaults
internal/mithril-dmq/src/consumer/pallas.rs Updated test cases to include kes_period values
internal/mithril-dmq/Cargo.toml Bumped version from 0.1.2 to 0.1.3
Comments suppressed due to low confidence (2)

internal/mithril-dmq/src/message.rs:145

  • After introducing kes_period into compute_msg_id, add a test verifying that two DmqMsg instances with different kes_period values produce different msg_ids to ensure the new field is properly hashed.
                kes_period: 0,

internal/mithril-dmq/Cargo.toml:4

  • After bumping the crate version, update the CHANGELOG (or relevant release notes) to document the addition of the kes_period field in DmqMsg.
version = "0.1.3"

@jpraynaud jpraynaud force-pushed the jpraynaud/2622-fix-kes-pallas branch from d7f4e35 to 841640e Compare July 15, 2025 12:53
@jpraynaud jpraynaud deployed to testing-preview July 15, 2025 13:11 — with GitHub Actions Active
@jpraynaud jpraynaud marked this pull request as ready for review July 15, 2025 13:13
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants