Alternative usage of random
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nc6 I think this PR might be of interest to you. I'd also appreciate your feedback if you do find time to provide it. 😉 |
neilmayhew
reviewed
Jun 27, 2025
Closed
lehins
force-pushed
the
lehins/simplify-random-usage
branch
from
dfa86b9 to
988ab2f
Compare
lehins
force-pushed
the
lehins/simplify-random-usage
branch
from
988ab2f to
6474b8c
Compare
neilmayhew
approved these changes
Jun 27, 2025
nc6
approved these changes
Jun 30, 2025
lehins
force-pushed
the
lehins/simplify-random-usage
branch
from
6474b8c to
c30a073
Compare
|
CC @jasagredo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implement support for
random-1.3This is an equivalent approach in the sense of semantics, but very different in how it is achieved.
Instead of defining
CapGenMthis PR utilizes an existingStateGenMprovided byrandompackage. The two things that were missing in order for us to be able to useStateGenMwas missing instances:MonadState(frommtl) forMRandomGenforGenStateI am not sure whether others will find this approach cleaner or easier to understand, but if we want to continue using the older approach, then #85 implements support for
random-1.3that also includes one of the simplifications present in this PR, namely removal offakeSeed