Skip to content

chore: fix slack notification message tag #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

amagyar-iohk
Copy link
Contributor

@amagyar-iohk amagyar-iohk commented May 23, 2024

Overview

Fixes tag link on release notification message

Checklists

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

@amagyar-iohk amagyar-iohk requested review from FabioPinheiro, mineme0110 and shotexa and removed request for mineme0110 May 23, 2024 03:34
Copy link

Unit Test Results

289 tests  ±0   288 ✔️ ±0   23s ⏱️ -2s
  36 suites ±0       1 💤 ±0 
  36 files   ±0       0 ±0 

Results for commit 9b89a01. ± Comparison against base commit 3d75ce9.

@atala-dev
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors
✅ JSON jsonlint 1 0
✅ JSON npm-package-json-lint yes no
✅ JSON prettier 1 0
✅ JSON v8r 1 0
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
✅ REPOSITORY grype yes no
⚠️ REPOSITORY kics yes 50
✅ REPOSITORY syft yes no
✅ REPOSITORY trivy-sbom yes no
⚠️ REPOSITORY trufflehog yes 1

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

@mkbreuningIOHK mkbreuningIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fixing the message with wrong link issue, so this is approved.
But I left a comment to discuss further and more sustainable solution.

@amagyar-iohk amagyar-iohk merged commit 94a31c5 into main May 23, 2024
5 checks passed
@amagyar-iohk amagyar-iohk deleted the tests/release-notification-tag-fix branch May 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants