Skip to content

The type of getSubscription method parameter changed to string #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2021
Merged

The type of getSubscription method parameter changed to string #750

merged 3 commits into from
Dec 7, 2021

Conversation

Jasminna
Copy link
Contributor

@Jasminna Jasminna commented Dec 7, 2021

OVERVIEW

Change the type of getSubscription id param from number to string

WHERE SHOULD THE REVIEWER START?

index.d.ts
src/constants/index.ts
src/endpoints/subscription.ts
src/models/Config.ts
src/models/ISubscription.ts

ANY NEW DEPENDENCIES ADDED?

List any new dependencies added.

  • Does it work in IE >= 11?
  • Does it work in other browsers?

CHECKLIST

Be sure all items are ✅ before submitting a PR for review.

  • Verify you bumped the lib version according to Semantic Versioning Standards
  • Verify you updated the CHANGELOG
  • Verify this branch is rebased with the latest master

@Jasminna Jasminna requested a review from a team December 7, 2021 08:30
@Jasminna Jasminna merged commit 4c419e9 into v3 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirovladimitrovski mirovladimitrovski mirovladimitrovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasminna @mirovladimitrovski