Skip to content

Add/disabled option in dropdown #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Conversation

mustran
Copy link
Contributor

@mustran mustran commented Sep 29, 2022

OVERVIEW

Add disabled option for dropdown options.

WHERE SHOULD THE REVIEWER START?

e.g. /src/elements/SomeComponent.js

HOW CAN THIS BE MANUALLY TESTED?

List steps to test this locally.

ANY NEW DEPENDENCIES ADDED?

List any new dependencies added.

  • Does it work in IE >= 11?
  • Does it work in other browsers?

SCREENSHOTS (if applicable)

Does your change affect the UI? If so, please add a screenshot.

CHECKLIST

Be sure all items arebefore submitting a PR for review.

  • Verify the linters and tests pass: yarn review
  • Verify you bumped the lib version according to Semantic Versioning Standards
  • Verify you updated the CHANGELOG
  • Verify this branch is rebased with the latest master

@mustran mustran requested a review from a team September 30, 2022 07:35
@mustran mustran self-assigned this Sep 30, 2022
@mustran mustran added the improvement General codebase or feature improvement label Sep 30, 2022
Copy link
Contributor

@Jasminna Jasminna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mustran mustran merged commit b779f6f into dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement General codebase or feature improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants