Skip to content

Keep consistency of asset previews in case of restricted asset & FooterText component refactored #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jan 25, 2022

Conversation

Jasminna
Copy link
Contributor

@Jasminna Jasminna commented Jan 21, 2022

OVERVIEW

Notion card: Passcode assets, geo restrictions, and asset preview

The following styling changes in preview templates are made:

  • set overlay on the top of the image or `filter: brightness(0.3) style property on image container
  • added new prop restrictedMessage for storing the restricted message
  • previews are now consistent and only restricted message is shown when asset is restricted
  • the width of restricted message container is decreased in order to fit into the image container in preview 6
  • FooterText component refactored

WHERE SHOULD THE REVIEWER START?

CHANGELOG.md
src/paywall-previews
src/paywall-previews/shared/FooterText.tsx

HOW CAN THIS BE MANUALLY TESTED?

yarn start

ANY NEW DEPENDENCIES ADDED?

List any new dependencies added.

  • Does it work in IE >= 11?
  • Does it work in other browsers?

SCREENSHOTS (if applicable)

Preview 1
image

Preview 2
image

Preview 3
image

Preview 4
image

Preview 5
image

Preview 6
image

Preview 7
image

CHECKLIST

Be sure all items arebefore submitting a PR for review.

  • Verify the linters and tests pass: yarn review
  • Verify you bumped the lib version according to Semantic Versioning Standards
  • Verify you updated the CHANGELOG
  • Verify this branch is rebased with the latest master

@Jasminna Jasminna requested a review from a team January 21, 2022 08:37
@Jasminna Jasminna changed the title Keep consistency of asset previews in case of restricted asset Keep consistency of asset previews in case of restricted asset & FooterText component refactored Jan 23, 2022
@Jasminna Jasminna merged commit 211ede2 into dev Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants