-
Notifications
You must be signed in to change notification settings - Fork 3
Keep consistency of asset previews in case of restricted asset & FooterText component refactored #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jasminna
merged 27 commits into
dev
from
improvement/asset-previews/geo-restricted-asset
Jan 25, 2022
Merged
Keep consistency of asset previews in case of restricted asset & FooterText component refactored #1397
Jasminna
merged 27 commits into
dev
from
improvement/asset-previews/geo-restricted-asset
Jan 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge dev into master
…trictedMessage is added)
…o improvement/asset-previews/geo-restricted-asset
…into improvement/asset-previews/geo-restricted-asset
…le changes related to restricted container
…. Conflicts resolved.
…ps://github.com/inplayer-org/inplayer-ui into improvement/asset-previews/geo-restricted-asset
…ps://github.com/inplayer-org/inplayer-ui into improvement/asset-previews/geo-restricted-asset
mustran
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVERVIEW
Notion card: Passcode assets, geo restrictions, and asset preview
The following styling changes in preview templates are made:
overlay
on the top of the image or `filter: brightness(0.3) style property on image containerrestrictedMessage
for storing the restricted messageWHERE SHOULD THE REVIEWER START?
CHANGELOG.md
src/paywall-previews
src/paywall-previews/shared/FooterText.tsx
HOW CAN THIS BE MANUALLY TESTED?
yarn start
ANY NEW DEPENDENCIES ADDED?
List any new dependencies added.
SCREENSHOTS (if applicable)
Preview 1

Preview 2

Preview 3

Preview 4

Preview 5

Preview 6

Preview 7

CHECKLIST
Be sure all items are ✅ before submitting a PR for review.
yarn review