Skip to content

bug(Reddit - Remove Notification Suggestion Dialog): Patch not working in Reddit 2025.03 #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
dustlucas opened this issue Jan 18, 2025 · 7 comments
Closed
7 tasks done
Labels
Bug report Something isn't working

Comments

@dustlucas
Copy link

Type

Cosmetic

Tools used

RVX Manager

Application

Reddit 2025.03.0

Bug description

When just opening a subreddit, the dialog does not appear, but when opening a post in the subreddit and returning to it's feed, it appear. It seems to only occur one time by subreddit, but it occurs again by changing subreddits that it still didn't happen.

Error logs

Solution

No response

Additional context

No response

Device Environment

Android 14
Oneu UI 6.1
Galaxy A54
Non-root

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@dustlucas dustlucas added the Bug report Something isn't working label Jan 18, 2025
@dustlucas
Copy link
Author

Image
Image
Image

@inotia00
Copy link
Owner

The fingerprint of this patch is quite weak, so even if the patch succeeds, it may have patched the wrong class.

Can you test if the patch works on Reddit 2025.01.0?

@dustlucas
Copy link
Author

The fingerprint of this patch is quite weak, so even if the patch succeeds, it may have patched the wrong class.

Can you test if the patch works on Reddit 2025.01.0?

It doesn't happen on 2025.01.0. I tried with different subreddits but the patch remained fully functional. With 02.0 there's that problem of the navigation bar disappearing, but the dialong didn't appear.

@inotia00 inotia00 changed the title bug(Reddit - Remove Notification Suggestion Dialog): Patch seems partially ineffective. bug(Reddit - Remove Notification Suggestion Dialog): Patch not working in Reddit 2025.03 Jan 19, 2025
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jan 19, 2025
@dustlucas
Copy link
Author

dustlucas commented Jan 19, 2025

@inotia00 seems fixed to me. Now, the problem I reported previously about the navigation bar disappearing returned, but it might be an upstream bug. (Edit1: Just tested with official build and the bug is not present, probably because the notification dialog is shown)

Image
Image

@dustlucas
Copy link
Author

Those two bugs only started from +2025.02.0

@inotia00
Copy link
Owner

Reflected in revanced-patches-5.3.1

@dustlucas
Copy link
Author

Reflected in revanced-patches-5.3.1

thank you, it's working fine on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants