Skip to content

bug(RVX Manager): WARNING and INFO are not printed #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
KobeW50 opened this issue Dec 21, 2024 · 2 comments
Closed
8 tasks done

bug(RVX Manager): WARNING and INFO are not printed #2590

KobeW50 opened this issue Dec 21, 2024 · 2 comments
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Dec 21, 2024

Type

Error while patching

Tools used

RVX Manager

Application

Reddit 2024.29.0

Bug description

According to this line of code, it seems that a warning is meant to be printed to the patch log when the Hide navigation buttons patch is included when patching a version newer than 2024.17.0.

This warning is not present when patching 2024.29.0.

Error logs

- Device Info
RVX Manager: 1.23.5
Model: SM-S906U1
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.reddit.frontpage v2024.29.0 (Suggested: Any)
Patches version: v5.1.1
Patches added: Custom branding name for Reddit, Hide navigation buttons
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: true
Remove unused library: true
Use pre-release: false
Patches source: inotia00/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Applied 12 patches
Compiling modified resources
Ripping selected native libs
Aligning APK
Signing APK
Patched APK
Installing patched app
Installed

Solution

No response

Additional context

I have not tested with a CLI-based patching tool. Let me know if I should test using revancify, rvx-builder, or the CLI.

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I did not use pre-release (dev branch).
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@KobeW50 KobeW50 added the Bug report Something isn't working label Dec 21, 2024
@KobeW50 KobeW50 changed the title bug(Reddit - Hide navigation buttons): No warning is printed to patch log when patching 2024.18.xx or greater. bug(Reddit - Hide navigation buttons): No warning is printed to patch log when patching 2024.18.xx or greater Dec 21, 2024
@inotia00 inotia00 changed the title bug(Reddit - Hide navigation buttons): No warning is printed to patch log when patching 2024.18.xx or greater bug(RVX Manager): No warning is printed Dec 22, 2024
@inotia00
Copy link
Owner

When patching other apps, not just Reddit, RVX Manager does not print any type of warnings

Printing warnings is a feature implemented only in RVX patches, so it is a valid issue related to RVX Manager

@inotia00 inotia00 changed the title bug(RVX Manager): No warning is printed bug(RVX Manager): WARNING and INFO are not printed Dec 22, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Dec 22, 2024
@inotia00
Copy link
Owner

reflected in revanced-patches-5.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants