Skip to content

feat(telemetry/relayer): improve monitoring of persistent packet data query failures #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GarmashAlex
Copy link

@GarmashAlex GarmashAlex commented May 29, 2025

Closes: #4298

Description

This PR improves the monitoring of persistent packet data query failures in Hermes.
The following changes were made:
crates/telemetry/src/state.rs:

  • Added a new metric (persistent_packet_data_query_failures) to track repeated or persistent failures when querying packet data for relaying. This helps distinguish between transient and long-standing issues.
    crates/relayer/src/link/packet_events.rs:
  • Integrated the new metric, incrementing it whenever a chunk of packet sequences fails to return any events (i.e., persistent missing packet data).
    crates/relayer/src/link/relay_path.rs:
  • Refactored to propagate telemetry_state into packet event query functions, enabling the new metric to be updated in relevant code paths.

Most critical files to review:

  • crates/telemetry/src/state.rs
  • crates/relayer/src/link/packet_events.rs
  • crates/relayer/src/link/relay_path.rs

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
    • If guide has been updated, tag GitHub user mircea-c
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@GarmashAlex GarmashAlex changed the title Hpp1 feat(telemetry/relayer): improve monitoring of persistent packet data query failures May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve missing packet data monitoring
1 participant