Introduce runner and override makeConfig #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/informalsystems/security-partner-internal-pm/issues/78
[ext][Berachain] Change configuration generation in runner to generate beacond-compatible config
go.modValidatorandMakeCommitFromVoteSetfrom theinternal/testspackage to evidence handling.mapstructureas beaconkit uses a newer version of viper than CometBFT and the new version is not compatible.makeConfigfunction to use beaconkit's DefaultConfig, instead of CometBFT.(A diff between the cometbft branch and this code will show the differences nicely.)
Note: There is a newer version of the runner in the main branch of berachain/cometbft, but beaconkit does not use the latest version.