-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add ipmi plugin #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipmi plugin #888
Conversation
Overall looks good, thank you @ebookbug for the contribution, but two things I will need to merge:
|
OK,finished. |
for i := 0; i < len(lines); i++ { | ||
vals := strings.Split(lines[i], "|") | ||
if len(vals) == 3 { | ||
tags := map[string]string{"host": conn.Hostname, "inst": trim(vals[0])} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change "host" to "server" (so that we don't override the builtin "host" tag key)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default host tag will use the local hostname which the telegraf agent running on,but ipmi plugin collect remote bare metal host's metric.
I think the local hostname is not usable,but a more tag will increase the series cardinality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is now an option to disable the default hostname, please change host to server
The tags have changed to 'server','name'. |
This plugin wants to collect the sensor metrics of bare metal.
Unlike the sensor plugin,the ipmi plugin will collect remote sensor metrics using ipmitool in linux
One plugin can collect multiple bare metal hosts.