fix(inputs.opcua): Fix integration test for consecutive session error #17201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/opcua
fix
srebhan
added
the
ready for final review
mstrandboge
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original test was assuming a default threshold of 2, but our new implementation uses a default of 1. By explicitly setting the threshold to 2 in this test, it will behave as expected and properly test the multi-error scenario.
This way:
TestReconnectErrorThresholdDefaultIntegrationtests the default behaviour (threshold = 1)TestConsecutiveSessionErrorRecoveryIntegrationtests multi-error scenarios (threshold = 2)TestReconnectErrorThresholdThreeIntegrationtests the threshold = 3 caseChecklist
Related issues