Skip to content

fix: using UTC timezone for alert levels #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

vlastahajek
Copy link
Contributor

Required checklist

  • Sample config files updated (both /etc folder and NewDemoConfig methods) (influxdb and plutonium)
  • openapi swagger.yml updated (if modified API) - link openapi PR
  • Signed CLA (if not already signed)

Description

Forcing batch alert time timezone to UTC. Fixes #938 and EAR #5376
Stream alert also has the time in the UTC zone.

Context

Affected areas (if applicable):

The .Time variable printed as a string will always be in UTC.

Severity (optional)

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@vlastahajek vlastahajek marked this pull request as draft August 21, 2024 11:39
@vlastahajek vlastahajek marked this pull request as ready for review August 22, 2024 11:50
@bednar bednar requested review from karel-rehor and alespour August 22, 2024 12:26
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes sense. Consistency with stream alerts is a great outcome. Tests checks what is needed.

Copy link
Collaborator

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Changes make sense.

@vlastahajek vlastahajek merged commit d28bb07 into master Aug 26, 2024
3 checks passed
@vlastahajek vlastahajek deleted the fix/alert-timezone branch August 26, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Time returns different timezone
3 participants