Skip to content

build(deps): Bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 15, 2025

👋 Build with Go 1.25 fails with:

  ...
  go generate -tags '' ./libflux/go/libflux
  env GO111MODULE=on go build -tags '' ./...
  go: downloading github.com/dave/jennifer v1.2.0
  go: downloading golang.org/x/mod v0.18.0
  # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
  make: *** [build] Error 1

Bumped via:

go1.25rc1 get -u golang.org/x/tools
go: upgraded golang.org/x/crypto v0.36.0 => v0.39.0
go: upgraded golang.org/x/mod v0.24.0 => v0.25.0
go: upgraded golang.org/x/net v0.38.0 => v0.41.0
go: upgraded golang.org/x/sync v0.12.0 => v0.15.0
go: upgraded golang.org/x/sys v0.31.0 => v0.33.0
go: upgraded golang.org/x/term v0.30.0 => v0.32.0
go: upgraded golang.org/x/text v0.23.0 => v0.26.0
go: upgraded golang.org/x/tools v0.30.0 => v0.34.0

go1.25rc1 mod tidy

Related:

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

…lity

Build with Go 1.25 fails with:
  go generate -tags '' ./libflux/go/libflux
  env GO111MODULE=on go build -tags '' ./...
  go: downloading github.com/dave/jennifer v1.2.0
  go: downloading golang.org/x/mod v0.18.0
  # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
  make: *** [build] Error 1

Bumped via:
go1.25rc1 get -u golang.org/x/tools
go: upgraded golang.org/x/crypto v0.36.0 => v0.39.0
go: upgraded golang.org/x/mod v0.24.0 => v0.25.0
go: upgraded golang.org/x/net v0.38.0 => v0.41.0
go: upgraded golang.org/x/sync v0.12.0 => v0.15.0
go: upgraded golang.org/x/sys v0.31.0 => v0.33.0
go: upgraded golang.org/x/term v0.30.0 => v0.32.0
go: upgraded golang.org/x/text v0.23.0 => v0.26.0
go: upgraded golang.org/x/tools v0.30.0 => v0.34.0

go1.25rc1 mod tidy

Related:
* Go proposal: golang/go#73205
* Upstream `golang.org/x/tools` fix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b
* Problem found in Homebrew/homebrew-core#226636
@mhilton mhilton merged commit 0c5580e into influxdata:master Jun 16, 2025
10 checks passed
@mhilton
Copy link
Contributor

mhilton commented Jun 16, 2025

Thankyou @stefanb

@stefanb
Copy link
Contributor Author

stefanb commented Jun 16, 2025

Please don't forget to make a release sometime before or right after go 1.25 release.

@stefanb stefanb deleted the bump-golang-x-tools branch June 16, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants