-
Notifications
You must be signed in to change notification settings - Fork 156
chore(deps): replace usage of github.com/pkg/errors with stdlib #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
181e4ce
to
586db98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code that is here is fine, there are a couple of problems that prevent it from merging though.
- The commit messages should be in the semantic style
- The change has exposed a poorly written error message which has upset
staticcheck
.
I think applying this patch will cause the test to pass. diff --git a/internal/cmd/influxql-decode/main.go b/internal/cmd/influxql-decode/main.go
index 791067da..24cfa563 100644
--- a/internal/cmd/influxql-decode/main.go
+++ b/internal/cmd/influxql-decode/main.go
@@ -23,7 +23,7 @@ var rootCmd = &cobra.Command{
case 2:
return v2(cmd, args)
default:
- return errors.New("Target version can only be 1 or 2.")
+ return errors.New("target version can only be 1 or 2")
}
},
} |
Thanks for the review, @mhilton. I've fixed the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has broken a test.
Thanks for your patience @hazzik. |
Remove usage of now archived github.com/pkg/errors package with stdlib
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/
docs/Spec.md
has been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.