Dump fulltext index #2336
Merged
Dump fulltext index #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: writinwaters <[email protected]>
Co-authored-by: writinwaters <[email protected]>
JinHai-CN
reviewed
Dec 6, 2024
| @@ -35,6 +35,11 @@ protected: | |||
| auto *memindex_tracer = InfinityContext::instance().storage()->memindex_tracer(); | |||
| memindex_tracer->AddMemUsed(mem); | |||
| } | |||
|
|
|||
| void DecMemUsed(SizeT mem) { | |||
There was a problem hiding this comment.
How about change the function name to IncreaseMemoryUsage and DecreaseMemoryUsage
JinHai-CN
reviewed
Dec 6, 2024
| @@ -30,7 +30,7 @@ import index_base; | |||
| import column_def; | |||
| import cleanup_scanner; | |||
| import chunk_index_entry; | |||
| import memory_indexer; | |||
| // import memory_indexer; | |||
JinHai-CN
reviewed
Dec 6, 2024
| private: | ||
| // call with write lock | ||
| void AddMemUsed(SizeT mem); |
There was a problem hiding this comment.
IncreaseMemoryUsage / DecreaseMemoryUsage
vsian
added a commit
to vsian/infinity
that referenced
this pull request
Dec 13, 2024
### What problem does this PR solve? Dump `MemoryIndexer` when the memory usage of the index exceeds the threshold. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) - [x] New Feature (non-breaking change which adds functionality) - [x] Test cases --------- Co-authored-by: writinwaters <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Dump
MemoryIndexerwhen the memory usage of the index exceeds the threshold.Type of change