fix: bug/issue 25 #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is really a final enhancement to the #25 'Handle Missing Keys' issue. We can now substitute missing settings with default app values, or we can type a new custom value in, all on initial app startup. FUTURE CONSIDERATIONS: If configuration management were to become more important in future, the following may need to be addressed: - If a whole section is missing with an inline comment, a different function parses the diff to the usual. Some of this code could be better shared with the main function. There's currently minor inconsistency. - Missing settings are declared as `root['app']['loglevel']`. This could be more human readable. e.g. `app -> loglevel` - Expected custom values are not parsed or validated properly. They're just taken as is. - If a whole setting section is missing. The default value is an ordereddict of all the missing nested key/vals within. This isn't human readable and it's **definitely** not possible to type out a single custom value to represent that whole structure, instead each nested key/val within should be iterated one-by-one. - This would all be necessary if we wanted to add a config command to the CLI, but surely YAML is easy enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all required settings exist.
Allow substitution with defaults or custom values at runtime.