fix: Remove dead Redis PubSub code #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/issue-224-Revisit-Redis-PubSub
Now just calculating progress and task info every iteration of the loop instead of checking new data flags. It looks like there may be a race condition of some sort causing inaccurate worker numbers. I might consider thread locks if they work with Redis' pubsub run_in_thread.
Alright, this is kind of funny. Turns out I've been reinventing the wheel this whole time. Celery's GroupResult contains AsyncResult instances with all the data we need to get active worker count, task completion and task encoding progress (with a custom task state definition). So: - dropped Redis database polling - dropped Redis PubSub - use unique worker IDs instead of sequential prefix to easily start additional workers at any time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😬 Accidentally left an old call to publish progress with Redis PubSub.