Skip to content

fix: Improved version constraint key generation #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Conversation

in03
Copy link
Owner

@in03 in03 commented Jun 14, 2022

Fixes #174

  • Using "petname" command available on Ubuntu default sources list instead of C# based Github action
  • Alliteration handled by petname command now
  • Complexity set to 0 for clear, concise names
  • Offset entropy loss from low-complexity setting by changing word chain length to 3 (was 2)

in03 added 5 commits June 15, 2022 09:26
Using `petname` library available in Ubuntu default apt sources
instead of Github action `Cyberbartels/petname` with C# dependencies.

petname --words 3 --complexity 0 --ubuntu

Much longer and complex words are available
but they become difficult to pronounce/read.

Also removed unecessary push, since it's covered by the auto-commit action.
Removed an extra push command in export requirements since auto-commit
action pushes if necessary anyway.
@in03 in03 merged commit 91a0262 into main Jun 14, 2022
@in03 in03 deleted the bug/issue-174/-vc-keygen branch June 14, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating alliteration character sometimes fails
1 participant