Skip to content

Move all handlers with user prompts from Tkinter messagebox to CLI prompts #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue May 16, 2022 · 1 comment
Closed

Move all handlers with user prompts from Tkinter messagebox to CLI prompts #103

github-actions bot opened this issue May 16, 2022 · 1 comment
Assignees
@in03
Labels
enhancement todo

Comments

@github-actions
Copy link
Contributor

Move all handlers with user prompts from Tkinter messagebox to CLI prompts

Reasoning: Tkinter doesn't always ship with python,

https://github.com/in03/Resolve-Proxy-Encoder/blob/23a4804c53d3b4d78c15f4913856f88699c50225/resolve_proxy_encoder/queuer/handlers.py#L32

tk_root.withdraw()


# TODO: Move all handlers with user prompts from Tkinter messagebox to CLI prompts
# Reasoning: Tkinter doesn't always ship with python,
# labels: enhancement


def handle_workers():
    """Detect amount of online workers. Warn if no workers detected.

93520690443199882fbb068a3ef123d20c6db4cf
in03 added a commit that referenced this issue May 18, 2022
@in03
feat(handlers): Swap TK msgbox to console prompts
5b4fa56 
Addresses #103

- Also addressed issue with multiple online Celery worker checks
@in03 in03 mentioned this issue May 18, 2022
Merged
in03 added a commit that referenced this issue May 18, 2022
@in03
Feat/issue103 (#107)
1661dc7 
* feat(handlers): Swap TK msgbox to console prompts

Addresses #103

- Also addressed issue with multiple online Celery worker checks

* feat(formatting): improve console output / logging
@github-actions
Copy link
Contributor Author

Closed in 1661dc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@in03 in03

Labels
enhancement todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@in03