-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(web): contenteditable div for multi-line text wrapping #19422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It might be simpler just to use comtenteditable on a normal div snd set the aria appropriately This can be done for all the places we use auto expanding text, like for album descriptions |
See also: https://github.com/immich-app/immich/blob/main/web/src/lib/actions/autogrow.ts -- but redoing that in content-editable would be better, since it works better on mobile devices (when viewing the web interface) |
78bd5b5
to
ecf6b17
Compare
44d2da4
to
998bd18
Compare
@midzelis i've updated the PR with contenteditable |
Description
input
with contenteditable div to allow multi-line wrapping of fields in the following areas/people
/explore
to make them more readableFixes #17967
How Has This Been Tested?
e2e/
cover the editing of fieldsScreenshots (if appropriate)
Checklist:
src/services/
uses repositories implementations for database calls, filesystem operations, etc.src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/
)