Skip to content

fix(web): wrap long names with textarea #19301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

jinxuan-owyong
Copy link
Contributor

Description

Replaced input with textarea since they do not support multi-line wrapping to display long names

Fixes #17967 (web)

How Has This Been Tested?

  • Visually verified multi-line wrapping when editing the name
  • Long names are correctly formatted when the page is newly loaded

Screenshots (if appropriate)

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@alextran1502 alextran1502 enabled auto-merge (squash) June 19, 2025 15:57
@alextran1502 alextran1502 merged commit 747a721 into immich-app:main Jun 19, 2025
49 of 50 checks passed
zackpollard added a commit that referenced this pull request Jun 19, 2025
alextran1502 pushed a commit that referenced this pull request Jun 19, 2025
Revert "fix(web): wrap long names with textarea (#19301)"

This reverts commit 747a721.
@bo0tzz
Copy link
Member

bo0tzz commented Jun 19, 2025

FYI @jinxuan-owyong this was reverted.

@jinxuan-owyong
Copy link
Contributor Author

Got it, will look into alternative solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for longer names
4 participants