fix(server): Allow saving empty description tag to sidecar #19178
+52
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, clearing an embedded
Description
orImageDescription
tag is not possible when the file contains an embedded entry. ExifTool treats an empty string as a directive to delete the tag, meaning it will fall back to reading the embedded tag if the sidecar's tag is not defined. This change enables writing an empty string to the sidecar for these tags, thereby overriding the embedded description and effectively clearing it from the asset's displayed metadata.Fixes #15990
Fixes #19168
Added new e2e test. (requires updated asset : immich-app/test-assets#18 )
sidecar with empty tags
Checklist:
src/services/
uses repositories implementations for database calls, filesystem operations, etc.src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/
)