feat(mobile): sort places by distance #17740
Draft
+226
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is an enhancement or a feature, feel free to change it :) |
mertalev
reviewed
Apr 24, 2025
Comment on lines
+156
to
+173
| places.sort((a, b) { | ||
| final double distanceA = calculateDistance( | ||
| currentLocation!.latitude, | ||
| currentLocation!.longitude, | ||
| a.latitude, | ||
| a.longitude, | ||
| ); | ||
| final double distanceB = calculateDistance( | ||
| currentLocation!.latitude, | ||
| currentLocation!.longitude, | ||
| b.latitude, | ||
| b.longitude, | ||
| ); | ||
|
|
||
| return isAscending.value | ||
| ? distanceA.compareTo(distanceB) | ||
| : distanceB.compareTo(distanceA); | ||
| }); |
There was a problem hiding this comment.
This kind of thing is usually indexed. Can you test how long it takes to brute force it like this with maybe 5000 places?
Comment on lines
+170
to
+172
| return isAscending.value | ||
| ? distanceA.compareTo(distanceB) | ||
| : distanceB.compareTo(distanceA); |
There was a problem hiding this comment.
It's generally better to move this outside of the inner sort function and have separate variants to keep the sort function branchless.
| } else { | ||
| // Sort places by name | ||
| places.sort( | ||
| (a, b) => isAscending.value |
Comment on lines
+47
to
+48
| latitude: data.exifInfo!.latitude!.toDouble(), | ||
| longitude: data.exifInfo!.longitude!.toDouble(), |
There was a problem hiding this comment.
Is this actually safe? These values can be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked by #17882
Description
Added the ability to sort the places by distance (from nearest to furthest) from the user's location.
How Has This Been Tested?
Screenshot