Skip to content

Comments button shows wrong comments on the mobile app #16185

Open
@wndenis

Description

@wndenis

The bug

It seems that the album comments button on the mobile app is a bit broken:

  1. First it leads to all comments in this album
  2. When we open any asset (in this album or not), it starts leading to the comments of the last opened asset
  3. Using this, we can leave a comment on any asset we previously opened

Consider this album setup:

Image


You can leave a comment to the photo outside the album when using the mobile app

Image

When clicking on this broken photo we get this error:

Image

But in case the commented user uses partner sharing with us, the photo is viewable (as in the first image), and we can even comment on it


Also want to note, but I'm not sure if it is work as expected:

  • Asset-related comments remain if we remove the asset from the album (comments count and their contets remains)
  • Asset-related comments remain if we trash the asset (comments count decreases, but they are still viewable, for example, it shows 4 comments count but we can see 6 comments)
  • And only if we delete the asset completely, then the comments disappear

It also would be cool to have TextCapitalization.sentences on the keyboard in the comments section

The OS that Immich Server is running on

Ubuntu 20.04.6 LTS

Version of Immich Server

v1.126.1

Version of Immich Mobile App

1.126.1 build.184

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

n/a

Your .env content

n/a

Reproduction steps

  1. Start the app (force close it first)
  2. Create an album, add users to it
  3. Navigate to your own library and tap to view any backed up asset
  4. Swipe down the asset and navigate back to our album
  5. Tap the comments button
  6. Write a comment
  7. Now the album has a comment linked to the last viewed photo even if it is not inside the album

Relevant log output

Additional information

Using Samsung Galaxy S22 Ultra, Android 14, but not sure if it is platform dependant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions