-
Notifications
You must be signed in to change notification settings - Fork 32
Allow users to specify custom tokens #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new input parameter 'token' to allow users to specify a custom GitHub token for authentication, with a default value of ${{ github.token }}. The action now uses this custom token for GitHub CLI authentication instead of the hardcoded github.token. User journey diagram for specifying custom tokensjourney
title User journey for specifying custom tokens
section Token Specification
User: Specify custom token: 5: User
System: Use specified token for authentication: 5: System
System: Default to ${{ github.token }} if not specified: 3: System
section Authentication
System: Authenticate using specified token: 5: System
System: Authenticate using default token if custom not provided: 3: System
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CompeyDev - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief comment or documentation about when and why a user might want to use a custom token, and any security considerations they should be aware of when using this feature.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thank you! |
This allows the user to specify their token using a
token
input, defaulting to the regular${{ github.token }}
if not.Summary by Sourcery
New Features: