Clippy #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fintelia merged 1 commit into image-rs:main from awxkee:clippy_3_25

Mar 17, 2025

Contributor

awxkee commented Mar 17, 2025

The new version of Clippy started suggesting changing Read to BufRead, but since there is a trait, I believe this suggestion is not applicable.

warning: calling .bytes() is very inefficient when data is not in memory
   --> src/codecs/pnm/decoder.rs:767:25
    |
767 |         let mut bytes = reader.bytes();
    |                         ^^^^^^^^^^^^^^
    |
    = help: consider using `BufReader`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes


          Making clippy happy

0a6b84e

awxkee changed the title ~~Making clippy happy~~ Clippy

fintelia approved these changes

View reviewed changes

fintelia merged commit 95be339 into image-rs:main

31 of 32 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet