fix(ecs): Use DateTime.UtcNow.Ticks instead of Stopwatch.GetTimestamp #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GetTimestamp uses QueryPerformanceFrequency which should be better performant and acurate. if you show me some repro code i can take a look at the bug you're running into |
|
@ikkentim I don't really have a specific code for you to reproduce the problem, since I had this problem some time ago on my server and I had to publish my own version of SampSharp.Entities. Perhaps the example of aSpine could be used: https://discord.com/channels/758751593725558794/758944561132994570/959920070363070504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopwatch.GetTimestamp is causing issues on Linux. On this platform, timers run immediately instead of executing at the specified interval. This behavior does not occur on Windows, where the timer works as expected and runs at the correct interval.