Skip to content

Update Hungarian translations #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Taranyi
Copy link
Contributor

@Taranyi Taranyi commented Jun 2, 2025

The fuzzy translations were corrected and missing entries in files/lang/hu.po were filled in.

Major Changes:

  • Updated the “Select color” string to the correct Hungarian translation “Szín kiválasztása.”
  • Added a translation for the message about ownership when no players exist on the map.
  • Filled in “ABOUT” and “About” with “NÉVJEGY” and “Névjegy.”
  • Translated the note-editing prompt from the map creator.
  • Fixed the quest failure message when the enemy finds the artifact.
  • Corrected the language name “Greek” to “görög.”
  • Added missing text for the black cat encounter and the cat events.
  • Overwrite some existing translation

@zenseii zenseii added improvement New feature, request or improvement translation Things related to languages and translations labels Jun 2, 2025
@zenseii zenseii added this to the 1.1.9 milestone Jun 2, 2025
@Taranyi
Copy link
Contributor Author

Taranyi commented Jun 2, 2025

The pull request still needs some refinement.

@Taranyi Taranyi marked this pull request as ready for review June 2, 2025 09:52
@ihhub ihhub requested review from zenseii and ihhub June 3, 2025 11:24
@zenseii
Copy link
Collaborator

zenseii commented Jun 6, 2025

@big4billy, your opinion on this PR would be very much appreciated if you have the time and want to.

@@ -461,7 +462,7 @@ msgid "%{name} has turned on the auto combat"
msgstr "%{name} bekapcsolta az automata csata módot"

msgid "Spell failed!"
msgstr "A varázslat meghiúsult!"
msgstr "A varázslat nem sikerült!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's matter of sense of taste. The new expression more or less synosym of the original, but "meghiúsul" means the spell couldn't impact. However "nem sikerül" better means "wasn't able to do it". I suggest to keep the original.

@@ -2883,7 +2884,7 @@ msgid "Attack Skill"
msgstr "Támadóerő"

msgid "Defense Skill"
msgstr "Védőerő"
msgstr "Védekezőerő"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend it. The new word longer and has no additional meaning.

@@ -3371,7 +3372,7 @@ msgid "Attack:"
msgstr "Támadóerő:"

msgid "Defense:"
msgstr "Védőerő:"
msgstr "Védekezőerő:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend it. The new word longer and has no additional meaning.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add that this text appears in the Hero Screen and the space available for the skill name is limited. I suggest to check the game if it even fits this new translation.

@@ -5820,15 +5822,14 @@ msgid ""
"They are triumphant."
msgstr ""
"Az ellenfél elfoglalta %{name} várat!\n"
"Ők győztek."
"Ővék a győzelem."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synonyms. Matter of taste.

@@ -475,7 +476,7 @@ msgid "You have already cast a spell this round."
msgstr "Már varázsoltál ebben a körben."

msgid "That spell will have no effect!"
msgstr "Ez a varázslat nem hatásos senkire!"
msgstr "Ennek a varázslatnak nem lesz semmilyen hatása!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synonyms. Matter of taste.

@@ -5871,7 +5872,7 @@ msgstr ""
"Az ellenfelek összes hősének legyőzése és várainak, városainak elpusztítása."

msgid "Your side defeats the opposing side."
msgstr "Te vagy szövetségeseid legyőzik az ellenfeleket."
msgstr "Az ellenfelet vagy te győzöd le, vagy a szövetségeseid."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend it. More complicated sentence and sense of teste.

@big4billy
Copy link
Contributor

big4billy commented Jun 6, 2025

@big4billy, your opinion on this PR would be very much appreciated if you have the time and want to.

Thanks a lot! I had busy weeks recently so I couldn't make it up-to-date as usual. I put some recommendations.

Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Taranyi. I left one question. Please have a look.

@@ -688,7 +689,7 @@ msgid "Hero Screen"
msgstr "Hős képernyő"

msgid "Captain's Options"
msgstr "Kapitány beállítások"
msgstr "Kapitány beállításai"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this translates, but note that "Options" in this case refers to the Captain's choices of actions to do.
These are the captain's options:
image

@ihhub ihhub modified the milestones: 1.1.9, 1.1.10 Jun 11, 2025
@big4billy
Copy link
Contributor

big4billy commented Jun 16, 2025 via email

@zenseii
Copy link
Collaborator

zenseii commented Jun 16, 2025

@Taranyi, please address the comments we have made and post fixed by making a commit to this PR's branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants